Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid modifying names of DataTree objects with parents #9494

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Forbid modifying names of DataTree objects with parents #9494

merged 5 commits into from
Sep 14, 2024

Commits on Sep 13, 2024

  1. Forbid modifying names of DataTree objects with parents 

    This ensures that the tree cannot be in an inconsistent state.

Fixes pydata#9447
    @shoyer
    shoyer committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    7bdfb75 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Tom Nicholas <tom@cworthy.org>
    @shoyer @TomNicholas
    shoyer and TomNicholas authored Sep 14, 2024
    Configuration menu
    Copy the full SHA
    c035f18 View commit details
    Browse the repository at this point in the history

  2. clean-ups per review

    @shoyer
    shoyer committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    25cd44b View commit details
    Browse the repository at this point in the history

  3. revert _post_attach

    @shoyer
    shoyer committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    5ed32fd View commit details
    Browse the repository at this point in the history

  4. fix assert message

    @shoyer
    shoyer committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    8020901 View commit details
    Browse the repository at this point in the history