Update Datatree html repr to indicate inheritance #9633
+53
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
added
topic-html-repr
topic-DataTree
| ) | ||
|
|
||
|
|
||
| def datatree_node_repr(group_title: str, node: DataTree, show_inherited=False) -> str: |
There was a problem hiding this comment.
I assume this logic now basically matches that in datatree_repr?
TomNicholas
commented
Oct 17, 2024
Comment on lines
+336
to
+339
| # TODO how can we assert that the Inherited coordinates section does not appear in the child group? | ||
| # with xr.set_options(display_style="html"): | ||
| # child_html = dt["a"]._repr_html_().strip() | ||
| # assert "Inherited coordinates" not in child_html |
There was a problem hiding this comment.
I'm not really sure how to test this any better. Both the correct and incorrect behaviour would give "Inherited coordinates" present somewhere in the long html repr text output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML version of #9470.
Haven't written any tests yet, but in this notebook it looks like it works.