move scalar-handling logic into possibly_convert_objects
#9900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
dcherian
approved these changes
Dec 17, 2024
|
This seems an undisputed change up to now if we count @spencerkclark in who suggested that change in #9618. Getting this in soon. |
spencerkclark
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Thanks @kmuehlbauer, yes, I'm on board with this update. Sorry for being a bit absent from the discussion over the last few weeks. I should be able to catch up on reviewing the bigger stuff over the holidays. I appreciate you splitting things off into smaller PRs!
|
Thanks @spencerkclark and no worries! |
|
Mypy errors are unrelated, getting this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst