Fix/155 change to return results from detect when recipe does not contain filters #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and values from specified tags.
… and values from specified tags. Changes inspired by modifications within howardpchen's fork of pydicom/deid.
Added sections describing the usage of the new private tag screening functionality which was added to the replace_identifiers method.
Changed default on screen_values from [] to None.
This reverts commit 54c636b.
This reverts commit 7c7a600.
…patterns and values from specified tags. Changes inspired by modifications within howardpchen's fork of pydicom/deid." This reverts commit f839e2f.
|
@vsoch - I have no clue what we did to include all of those remote-tracking merges... Let us know if we should do something different. |
|
When we merge PRs, I believe we squash and merge. So likely what you did here is rebase off of your master (with the older commits) - the changes you see are represented in master here, but since the commits are not, they appear here. If we squash and merge it should get rid of them all and just add one commit (and I'll ensure that the message doesn't include the old ones). And next time what you would want to do is generally always have your master in sync with deid master, meaning to never do a PR from your master to deid. |
vsoch
reviewed
Oct 2, 2020
vsoch
reviewed
Oct 2, 2020
vsoch
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues: #155
Change to return results from detect when recipe does not contain filters.
Checklist
Open questions
Questions that require more discussion or to be addressed in future development: