Fix to handle date fields with empty values #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check to prevent exception when JITTER action is performed on a field with a blank value.
vsoch
reviewed
Sep 21, 2021
deid/dicom/parser.py
Outdated
| @@ -465,7 +465,8 @@ def _run_action(self, field, action, value=None): | |||
| if value is not None: | |||
| # Jitter the field by the supplied value | |||
| new_val = jitter_timestamp(field=field, value=value) | |||
| self.replace_field(field, new_val) | |||
| if new_val is not None: | |||
There was a problem hiding this comment.
So this would be okay as an empty string?
There was a problem hiding this comment.
(or actually is it not possible to return that?)
There was a problem hiding this comment.
get_timestamp() currently only returns None or a formatted timestamp, but, I'll look for both just in case. Doesn't hurt to be extra careful.
Checking new value for space in addition to none
vsoch
approved these changes
Sep 21, 2021
|
Thank you @wetzelj ! |
|
Thank you @vsoch! You're always so speedy getting these things merged in... I really appreciate it! |
|
Oh don’t worry I updated it locally and just need to push the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check to prevent exception when JITTER action is performed on a field with a blank value.
Description
Related issues: #189
Checklist
Open questions
Questions that require more discussion or to be addressed in future development: