Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fixes and Unit Tests for BLANK & REPLACE Actions & Sequences #242

Merged
merged 21 commits into from
Dec 7, 2022
Merged

Bug Fixes and Unit Tests for BLANK & REPLACE Actions & Sequences #242

merged 21 commits into from
Dec 7, 2022

Commits on Nov 30, 2022

  1. Expand BLANK Action to other VRs 

    1. Expanded BLANK Action to other VRs.
2. Added unit tests for validating action interaction.
3. Added table of action interactions to help docs.
    @wetzelj
    wetzelj committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    b87e857 View commit details
    Browse the repository at this point in the history

  2. Update recipe-headers.md

    @wetzelj
    wetzelj committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    9e5c39b View commit details
    Browse the repository at this point in the history

  3. Update recipe-headers.md

    @wetzelj
    wetzelj committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    6365449 View commit details
    Browse the repository at this point in the history

  4. Bumping version and adding changelog

    @wetzelj
    wetzelj committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    62f1447 View commit details
    Browse the repository at this point in the history

  5. Fixed Linting Errors

    @wetzelj
    wetzelj committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    cdf099d View commit details
    Browse the repository at this point in the history

  6. Update test_action_interaction.py 

    Correcting bad test method names.
    @wetzelj
    wetzelj committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    80fec63 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Update deid-data install version

    @wetzelj
    wetzelj authored Dec 1, 2022
    Configuration menu
    Copy the full SHA
    6e7d299 View commit details
    Browse the repository at this point in the history

  2. Update parser.py 

    Reverted expand_field_expression to always return desired as a Tag.  Instead convert to DataElement in blank_field.
    @wetzelj
    wetzelj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    320bfd5 View commit details
    Browse the repository at this point in the history

  3. Expanding blank to all VRs 

    Updating BLANK test coverage to all VRs.
    @wetzelj
    wetzelj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    2ebe589 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Updating field counts in unit tests. 

    Updating unit tests failing due to field count changes in test image.
    @wetzelj
    wetzelj committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b722326 View commit details
    Browse the repository at this point in the history

  2. Update test_blank_action.py 

    Restructured blank_action unit tests.
    @wetzelj
    wetzelj committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    68832dd View commit details
    Browse the repository at this point in the history

  3. Fix for pydicom#244 - Replace fails for numeric VR

    @wetzelj
    wetzelj committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1dcae46 View commit details
    Browse the repository at this point in the history

  4. Fixing isort issue.

    @wetzelj
    wetzelj committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    94a4eaf View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md

    @wetzelj
    wetzelj committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b81a180 View commit details
    Browse the repository at this point in the history

  6. Update main.yaml 

    Removing deid-data pin.
    @wetzelj
    wetzelj authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    12f3518 View commit details
    Browse the repository at this point in the history

  7. Update deid/utils/actions.py 

    Co-authored-by: Vanessasaurus <814322+vsoch@users.noreply.github.com>
    @wetzelj @vsoch
    wetzelj and vsoch authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    8dcb703 View commit details
    Browse the repository at this point in the history

  8. Update actions.py 

    Committing review suggestions.
    @wetzelj
    wetzelj committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    86096a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Header Sequence Updates 

    Corrected issue pydicom#243 which prevented tags within sequences from being acted upon.   Added unit tests for sequence processing.
    @wetzelj
    wetzelj committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    8af88d4 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @wetzelj
    wetzelj committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    88123e3 View commit details
    Browse the repository at this point in the history

  3. Update test_replace_identifiers.py 

    Updated test_replace_identifiers to target ctbrain1.dcm by name.
    @wetzelj
    wetzelj committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    e543abd View commit details
    Browse the repository at this point in the history

  4. Update test_dicom_funcs.py 

    Updated test_user_provided_func to target ctbrain1.dcm
    @wetzelj
    wetzelj committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    a1f21a5 View commit details
    Browse the repository at this point in the history