Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker.md #262

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

nbelakovski-mssm
Copy link
Contributor

The second line calling deid locally after running the docker container doesn't make any sense. Also I think that adding --help helps to show how this docker container could be used.

Description

Related issues: N/A

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code follows the style guidelines of this project

Open questions

Questions that require more discussion or to be addressed in future development: N/A

@vsoch
Copy link
Member

vsoch commented Jun 17, 2024

@nbelakovski-mssm the CI failure is not your fault - we just need to update the formatter. I'll fix this and give you something to rebase against.

The second line calling deid locally after running the docker container doesn't make any sense. Also I think that adding `--help` helps to show how this docker container could be used.
@vsoch vsoch merged commit 5a3a8fe into pydicom:master Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants