Stabilize public API #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the only case I can think of where this is necessary is if you want null as a default in ColExpr.map (if you pass None, it recognizes it as a missing argument and uses the expression map was called on as a default.
Explicit annotations are much more readable and these will likely not change in the future.
Remove the builtin_verb decorator. We still need to decide whether materialize should fail on a dataframe backend or do nothing.
includes self-join detection and seeing whether a column is actually in the table
alias() currently breaks table references which is necessary for self-joins to work. We could add another verb that doesn't do that.
subqueries were falsely generated for window functions nested inside ewise functions, even though they are not required there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The API is not finished yet. We still need to add many more types, but before we do this we need to have a clear plan with the internal type system.