Oplog skipped even if config.OPLOG=True #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for resource name validity is being reversed.
|
Hello, is this supposed to fix #1074? Thanks! |
|
@nicolaiarocci Yes, it is supposed to fix that. |
|
Would be great if you could add a regression test here. |
nicolaiarocci
added a commit
that referenced
this pull request
Mar 30, 2018
The original test was a false positive.
nicolaiarocci
added a commit
that referenced
this pull request
Mar 30, 2018
|
Added a regression test (or I should say: fixed a false positive test), rebased and merged. Thanks. |
lexhung
added a commit
to lexhung/eve
that referenced
this pull request
Dec 12, 2018
* upstream/master: (32 commits) Get rid of unwanted .vscode folder Add support for mongo $box geo query operator Marsch Huynh Improve partial downloads documentation Changelog for pyeve#1050 Test coverage for pyeve#1050 A little refactoring (DRY). Addresses pyeve#1050. fix: media endpoint Support partial request for media resource Officially deprecate Python 2.6 Changelog for pyeve#1130 Reduced error description details Fix PUT behavior with User-Restricted Resource Access flake8 typo Hung Le Changelog for pyeve#1095. Regression test for PR pyeve#1095. Oplog skipped even if confg.OPLOG=True DHuan ...
This was referenced Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for resource name validity is being reversed.