1123 sub document validate filters #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaiarocci
requested changes
Mar 26, 2018
eve/utils.py
Outdated
| return "filter on '%s' not allowed" % key | ||
| if '*' not in allowed: | ||
| def recursive_check_allowed(filter_key, allowed_filters): | ||
| # Filter key can be a plain key (e.g. "foo") or a dotted |
There was a problem hiding this comment.
I would rather move this comment to the documentation.
There was a problem hiding this comment.
Hi @nicolaiarocci , thanks for your review!
Just to be sure, did you mean ALLOWED_FILTERS? Also, do you want me to remove this comment from the code once it will be present in the documentation?
There was a problem hiding this comment.
Yes, remove it from the code. And yes that's what I meant.
There was a problem hiding this comment.
Ok, I updated the PR with the requested changes ;)
…ic 'allowed_filters' settings
nicolaiarocci
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1123
Also, commit bae6757 fixes the behavior of
ALLOWED_FILTERS(and the related resource-specificallowed_fillters) settings in the same scenario as the one defined in #1123, i.e. filtering on a sub-document field.