Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock down xlrd to restore .xlsx support #41

Merged
merged 2 commits into from
Dec 12, 2020
Merged

Lock down xlrd to restore .xlsx support #41

merged 2 commits into from
Dec 12, 2020

Conversation

pcarn
Copy link
Contributor

@pcarn pcarn commented Dec 11, 2020 •
edited
Loading

The readme says it supports .xlsx, but xlrd released v2 this morning which removes .xlsx support. Since this is unpinned, it's broken as is right now.

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@chfw
Copy link
Member

chfw commented Dec 12, 2020

thanks for the heads-up!

@chfw chfw merged commit ced153d into pyexcel:dev Dec 12, 2020
chfw added a commit that referenced this pull request Dec 12, 2020
@chfw
📚 the correct place to update dependencies in pyexcel family. related…
6003fc3 
…t to #41
chfw added a commit that referenced this pull request Dec 12, 2020
@chfw
📚 and update change log. related to #41
22d7b59
chfw added a commit that referenced this pull request Dec 12, 2020
@chfw
Prepare 0.6.2 (#42)
19013b6 
* 📚 the correct place to update dependencies in pyexcel family. relatedt to #41

* 📚 and update change log. related to #41

* This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst

Co-authored-by: chfw <chfw@users.noreply.github.com>
@chfw chfw mentioned this pull request Dec 12, 2020
Merged
@chfw chfw mentioned this pull request Jan 21, 2021
Closed
@chfw chfw mentioned this pull request Feb 22, 2021
Closed
@berndf berndf mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcarn @chfw