Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

Create a workspace with serde_cbor as a member. #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create a workspace with serde_cbor as a member. #184

wants to merge 1 commit into from

Conversation

ahmedcharles
Copy link

No description provided.

@stevenroose
Copy link
Contributor

What is the motivation for this change? Without any other package in the top-level it doesn't make much sense to me to do this.

@ahmedcharles
Copy link
Author

The context is the discussion in #179. I have other changes locally which build on this, but they are perhaps more controversial, so I figured I'd make a fairly simple change which would help avoid merge conflicts and show incremental progress. But there's no interest...

@stevenroose
Copy link
Contributor

I don't see the idea of a workspace mentioned in #179 at all...

@ahmedcharles
Copy link
Author

It's implied by the mention of splitting the crate into a low level crate and one for just the serde integration.

@hansl
Copy link

hansl commented May 28, 2020

Please see my fork and branch. There is a workspace there, but there's no need to have this here as a stepping stone.

@ahmedcharles
Copy link
Author

I did look at your branch. It seems more like a rewrite than an incremental improvement. The primary reason I wanted to merge this is because I'd prefer reasoning about changes as incremental improvements rather than being forced to commit to one huge change all at once.

It seems like there isn't any interest in that, however.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants