Add support for Python 3.12 #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
force-pushed
the
py312
branch
5 times, most recently
from
8c87d6e to
ec5899b
Compare
|
Amazing work !! |
DanielNoord
reviewed
Jun 22, 2023
|
Next: assess Windows failure. |
DanielNoord
reviewed
Jun 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
==========================================
+ Coverage 92.80% 92.92% +0.12%
==========================================
Files 94 95 +1
Lines 10840 10918 +78
==========================================
+ Hits 10060 10146 +86
+ Misses 780 772 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I'll squash the fixups now. Doesn't sound like anybody has pulled down the branch locally. Should be easier for the next person to review. |
jacobtylerwalls
force-pushed
the
py312
branch
3 times, most recently
from
8d477de to
b9cf54b
Compare
timedelta was optimized in Python 3.12. Use a class from difflib to maintain the sense of the original test.
A C-accelerator was introduced for the typing module in Python 3.12 (see python/cpython#103764). Because a pure python source is no longer available, now we stub out the missing classes and provide some __class_getitem__ methods to allow subscripting like Type[int]. This may mean when 3.12 is the minimum, we can remove older brain features like infer_typing_alias().
The way ByteString was deprecated altered its mro(), breaking the way these tests located ABCMeta as a metaclass ancestor.
Follow the example of MatchStar and the like
|
Rebasing so that Coverage will pass (it's comparing against an older commit on main). |
Pierre-Sassoulas
approved these changes
Jun 25, 2023
|
(Weirdly, it's reporting that the docstring isn't covered.) |
|
Thanks for the reviews! If we cut an astroid alpha with this soon, I can get started on 3.12 compatibility for pylint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
I suggest reviewing by commit to see the messages. (Let's rebase & merge.)
The major new feature (closes #2201): add
TypeVarandTypeAliasnodes.The others are small adjustments for python implementation details that changed in 3.12.