Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newstyle variable given old-style class support should be removed #2561

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

akamat10
Copy link
Contributor

Type of Changes

Type
✨ New feature
🔨 Refactoring

Description

Remove newstyle from ClassDef and code associated with old-code style. Given newstyle will no longer be available, code externally accessing this will break and will need to stop using this including pylint. I haven't cleaned up postinit and visit_classDef to remove the newstyle parameter. Open to whether the should be removed too.

Closes #2560

@akamat10 akamat10 marked this pull request as ready for review September 11, 2024 04:06
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (e442776) to head (b8dd663).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2561      +/-   ##
==========================================
+ Coverage   92.99%   93.05%   +0.06%     
==========================================
  Files          93       93              
  Lines       11086    11046      -40     
==========================================
- Hits        10309    10279      -30     
+ Misses        777      767      -10     
Flag Coverage Δ
linux 92.93% <100.00%> (+0.06%) ⬆️
pypy 93.05% <100.00%> (+0.06%) ⬆️
windows 93.03% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/helpers.py 95.36% <100.00%> (-0.10%) ⬇️
astroid/interpreter/objectmodel.py 93.81% <ø> (+0.53%) ⬆️
astroid/nodes/scoped_nodes/scoped_nodes.py 93.11% <100.00%> (+0.30%) ⬆️
astroid/objects.py 94.26% <ø> (+0.55%) ⬆️

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Sep 11, 2024
@DanielNoord DanielNoord merged commit b4ac0e2 into pylint-dev:main Sep 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code related to old-style classes
3 participants