-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap GeneratorModel methods into BoundMethod; remove redundant test #2584
wrap GeneratorModel methods into BoundMethod; remove redundant test #2584
Conversation
The LookupTest.test_generator_attributes contains outdated Python 2 code (doesn't run on Python 3). The test is superceded by GeneratorModelTest.test_model.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
==========================================
+ Coverage 93.10% 93.24% +0.13%
==========================================
Files 93 93
Lines 11065 11066 +1
==========================================
+ Hits 10302 10318 +16
+ Misses 763 748 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
A bit confused by the coverage report. Clearly, #L705 is covered by |
ad5cdb9
to
09bd85c
Compare
|
09bd85c
to
b6de90b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup thank you. The test missing a unittest.TestCase inheritance are a nice catch
The LookupTest.test_generator_attributes contains outdated Python 2
code (doesn't run on Python 3). The test is superceded by
GeneratorModelTest.test_model.
A part of getting rid of non-Module roots, see #2536
Supersedes #2563.