-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve consistency of JoinedStr inference #2622
Open
ericvergnaud
wants to merge
12
commits into
pylint-dev:main
Choose a base branch
from
ericvergnaud:improve-consistency-of-joinedstr-inference
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−16
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
efd9173
improve consistency of JoinedStr inference
aef56bd
add changelog
94fdc4e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 86d0cce
fix failing tests
5c6f158
Merge branch 'improve-consistency-of-joinedstr-inference' of github.c…
2937f21
clarify and improve test coverage
6736308
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 132cfb1
Merge branch 'main' into improve-consistency-of-joinedstr-inference
Pierre-Sassoulas c8da26f
drop custom flag and refactor MISSING_VALUE
aab9e17
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c2e0a6d
remove unused import
5d7e5f1
Merge branch 'improve-consistency-of-joinedstr-inference' of github.c…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, good spot. If we isolate this change I bet we could get quick consensus to merge it 👍