Prevent dataclass parsing from triggering DuplicateBasesError #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Needs review 🔍
DanielNoord
requested changes
Oct 30, 2024
There was a problem hiding this comment.
See my response in #2628 (comment)
I don't think this is the right solution and we should in fact try and understand if it is indeed Protocol that ends up twice, and if so, make sure to remove it and not consider it duplicate. Not by just ignoring the case but by determining a heuristic on which we can reliably consider it non-duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This PR prevents a crash described in #2628.
The dataclass parsing process in
brain/brain_dataclasses.pycallsClassDef.mromethod multiple times. Each time it can happen that the call raisesDuplicateBasesError(even if bases aren't really duplicated). Because this happens in parsing and not in the linting part, Pylint doesn't catchDuplicateBasesError. This causes Pylint to crash.The proposed solution is to add a flag to
ClassDef.mroto ignore duplicate bases of the same base class. The PR also updates unit tests to verify the correct behavior.Closes #2628