Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures with pylint 2.11.1 #338

Closed
risicle opened this issue Nov 21, 2021 · 1 comment
Closed

Test failures with pylint 2.11.1 #338

risicle opened this issue Nov 21, 2021 · 1 comment

Comments

@risicle
Copy link

risicle commented Nov 21, 2021

Hi,

In building the NixOS package for this, we noticed the tests started failing when we bumped our pylint from 2.10.2 to 2.11.1:

=================================== FAILURES ===================================
_____________ test_everything[func_noerror_foreign_key_attributes] _____________

test_file = FunctionalTest:func_noerror_foreign_key_attributes

    @pytest.mark.parametrize("test_file", TESTS, ids=TESTS_NAMES)
    def test_everything(test_file):
        # copied from pylint.tests.test_functional.test_functional
        LintTest = PylintDjangoLintModuleTest(test_file)
        LintTest.setUp()
>       LintTest._runTest()
E       AssertionError: Wrong results for file "func_noerror_foreign_key_attributes":
E       
E       Unexpected in testdata:
E         19: consider-using-f-string

pylint_django/tests/test_func.py:98: AssertionError
________________ test_everything[external_factory_boy_noerror] _________________

test_file = FunctionalTest:external_factory_boy_noerror

    @pytest.mark.parametrize("test_file", TESTS, ids=TESTS_NAMES)
    def test_everything(test_file):
        # copied from pylint.tests.test_functional.test_functional
        LintTest = PylintDjangoLintModuleTest(test_file)
        LintTest.setUp()
>       LintTest._runTest()
E       AssertionError: Wrong results for file "external_factory_boy_noerror":
E       
E       Unexpected in testdata:
E         25: consider-using-f-string
E         32: consider-using-f-string

pylint_django/tests/test_func.py:98: AssertionError

Full build log available at https://hydra.nixos.org/log/cd3f9k3rmly3d9k0zan0gazrb3znqhys-python3.8-pylint-django-2.4.4.drv where all requirements exact versions can also be seen.

This is pylint-django 2.4.4. Same issue on linux and macos builds.

carlio added a commit that referenced this issue Dec 28, 2021
… outputs, so adding these in. Also, fixing the consider-using-f-string warnings from tests (#338)
@carlio carlio mentioned this issue Dec 28, 2021
@carlio
Copy link
Member

carlio commented Dec 28, 2021

Fixed on the master branch now.

@carlio carlio closed this as completed Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants