Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple packaging fixes #137

Merged
merged 7 commits into from
Mar 12, 2018
Merged

Multiple packaging fixes #137

merged 7 commits into from
Mar 12, 2018

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Mar 9, 2018

There are 3 major changes here:

  1. Revert the dependency on Django instroduced in List Django as a dependency. Fix #96 #132 and convert it to optional dependency
  2. Fix the DjangoInstalled checker to actually work
  3. Add tests for all of the above plus a few more tests to build and sanity check the resulting packages.

@carlio , @JensTimmerman, @jakirkham please comment on this.

@atodorov
Revert "List Django as a dependency. Fix #96"
bb41fd7 
This reverts commit 9b520e9.

Apparently this is causing more problems than it solves, see:
#132
@atodorov
Add optional dependency for Django and update README
9aae2fe 
This commit adds an optional dependency for Django for users who
would like to have Django installed automatically when installing
pylint-django.

It also updates the text in README and adds an ISSUE_TEMPLATE which
warns the users not to report bugs if Django is not installed
automatically!
@atodorov
README formatting
9cb7434
@atodorov
Remove unused import
6e34b7a
@atodorov
Let DjangoInstalledChecker warn when Django isn't available
850bf83 
by ignoring the import failure Python will not produce a traceback
but instead let DjangoInstalledChecker do its job and warn the user.

I also add a CI build stage to test this scenario since we don't want
to continue if this isn't working. NOTE: tox doesn't allow us to easily
execute shell scripts and commands outside its virtualenv so I have to
resort to ugly bash escaping to make this work!

Finally properly fixes #96.
@atodorov
Add test invoking pylint_django when Django has been installed
2dbcb18 
in this case we expect no errors for setup.py
@atodorov
Build packages and perform package sanity tests. Fixes #136
58265d7
@coveralls
Copy link

Pull Request Test Coverage Report for Build 318

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 84.545%
Totals Coverage Status
Change from base Build 299: -0.3%
Covered Lines: 465
Relevant Lines: 550
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 318

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 84.545%
Totals Coverage Status
Change from base Build 299: -0.3%
Covered Lines: 465
Relevant Lines: 550
💛 - Coveralls

@JensTimmerman
Copy link

JensTimmerman commented Mar 11, 2018 •
edited
Loading

looks good to me 👍
Thank you for this change!

@atodorov atodorov merged commit 1aabc0d into master Mar 12, 2018
@atodorov atodorov deleted the packaging_fixes branch March 12, 2018 20:35
@JensTimmerman JensTimmerman mentioned this pull request May 23, 2018
Closed
@valeriupredoi valeriupredoi mentioned this pull request Sep 13, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov @coveralls @JensTimmerman