Fix Pyreverse duplicate arrows bug (#9029)

pylint-dev · Sep 16, 2023 · 3f93f1e · 3f93f1e
1 parent 6d9b07d
commit 3f93f1e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/doc/whatsnew/fragments/8522.bugfix b/doc/whatsnew/fragments/8522.bugfix
@@ -0,0 +1,3 @@
+Don't show arrows more than once in Pyreverse diagrams.
+
+Closes #8522
diff --git a/pylint/pyreverse/diagrams.py b/pylint/pyreverse/diagrams.py
@@ -225,9 +225,13 @@ def extract_relationships(self) -> None:
                         value, obj, name, "aggregation"
                     )
 
-            for name, values in list(node.associations_type.items()) + list(
-                node.locals_type.items()
-            ):
+            associations = node.associations_type.copy()
+
+            for name, values in node.locals_type.items():
+                if name not in associations:
+                    associations[name] = values
+
+            for name, values in associations.items():
                 for value in values:
                     self.assign_association_relationship(
                         value, obj, name, "association"

diff --git a/tests/pyreverse/functional/class_diagrams/attributes/duplicates.mmd b/tests/pyreverse/functional/class_diagrams/attributes/duplicates.mmd
@@ -14,4 +14,3 @@ classDiagram
     example2 : int
   }
   A --* DuplicateArrows : a
-  A --* DuplicateArrows : a
diff --git a/tests/pyreverse/functional/class_diagrams/attributes/duplicates.py b/tests/pyreverse/functional/class_diagrams/attributes/duplicates.py
@@ -8,7 +8,7 @@ def __init__(self):
         self.example2 = 2
 
 
-# OPEN BUG: https://github.com/pylint-dev/pylint/issues/8522
+# Test for https://github.com/pylint-dev/pylint/issues/8522
 class A:
     pass