Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for typing alias in isinstance calls #5089

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Add test for typing alias in isinstance calls #5089

merged 3 commits into from
Oct 7, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 28, 2021 •
edited
Loading

Depends on: pylint-dev/astroid#1192
Closes: #3507
Closes: #5087

@cdce8p cdce8p added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Sep 28, 2021
@cdce8p cdce8p changed the title Add regression test for 3507 Add test for 3507 Sep 28, 2021
@cdce8p cdce8p changed the title Add test for 3507 Add test for typing alias in isinstance calls Sep 28, 2021
@cdce8p cdce8p added this to the 2.11.2 milestone Sep 28, 2021
@cdce8p cdce8p added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Sep 28, 2021
@cdce8p cdce8p mentioned this pull request Sep 28, 2021
Merged
@coveralls
Copy link

coveralls commented Oct 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1317282930

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.199%
Totals Coverage Status
Change from base Build 1317279814: 0.0%
Covered Lines: 13539
Relevant Lines: 14527
💛 - Coveralls

@cdce8p cdce8p merged commit 2a343e8 into pylint-dev:main Oct 7, 2021
@cdce8p cdce8p deleted the regression_3057 branch October 7, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code Needs astroid update Needs an astroid update (probably a release too) before being mergable
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

typing.Callable False positive isinstance-second-argument-not-valid-type when testing typing.Iterable
3 participants
@cdce8p @coveralls @Pierre-Sassoulas