Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burst pylint.checkers base into multiple file #5489

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
🔨 Refactoring

Description

pylint.checker.base was 2600 lines long which was impacting analysis performance in IDE (more than 4s to get a new analysis after a save in Pycharm). This also permitted to find unused code and to remove it.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 7, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Dec 7, 2021
@coveralls
Copy link

coveralls commented Dec 7, 2021

Pull Request Test Coverage Report for Build 2036694117

  • 1130 of 1152 (98.09%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 94.167%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/checkers/base/name_checker/checker.py 248 250 99.2%
pylint/checkers/base/docstring_checker.py 85 88 96.59%
pylint/checkers/base/basic_checker.py 372 379 98.15%
pylint/checkers/base/basic_error_checker.py 211 221 95.48%
Totals Coverage Status
Change from base Build 2036452518: 0.07%
Covered Lines: 15289
Relevant Lines: 16236

💛 - Coveralls

@cdce8p cdce8p self-requested a review December 7, 2021 21:57
@cdce8p
Copy link
Member

cdce8p commented Dec 7, 2021

We should do #5221 first. I still need to look at that though.

@cdce8p cdce8p added the Blocked 🚧 Blocked by a particular issue label Dec 7, 2021
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Mar 24, 2022
@Pierre-Sassoulas Pierre-Sassoulas self-assigned this Mar 24, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 1c509ed into pylint-dev:main Mar 24, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the burst-pylint-checers-bases branch March 24, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants