Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bad-open-mode and unspecified-encoding documentation #5954

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Mar 24, 2022

  • Add yourself to CONTRIBUTORS.txt if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

Code examples based on pylint-errors and my own work.

Ref. #5953.

Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@@ -363,7 +363,7 @@ class StdlibChecker(DeprecatedMixin, BaseChecker):
"bad-open-mode",
"Python supports: r, w, a[, x] modes with b, +, "
"and U (only with r) options. "
"See https://docs.python.org/2/library/functions.html#open",
"See https://docs.python.org/3/library/functions.html#open",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.0 milestone Mar 24, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 7965f08 into pylint-dev:main Mar 24, 2022
@DanielNoord DanielNoord deleted the pylint-errors-1 branch March 24, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants