Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable usage of custom pylintrc file for message documentation tests #6131
Enable usage of custom pylintrc file for message documentation tests #6131
Changes from all commits
173c5d3
92fea5c
e6023e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielNoord I think we talked about this already before but what do you think about using
FunctionalTestFile
instead here ? At some point we will encounter the same issue than for functional tests (i.e. handling min_version, max_version, some options...). We could dotest_file.option_file
instead of recreating the logic a little differently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was actually my initial approach, but the problem is that
FunctionalTestFile
assumes the config file to have the same name as the.py
file.There is quite a good portion of code duplication also in the
LintModuleTest
class here.Besides the different folder structure, the tight coupling between the "original"
LintModuleTest
andtest_functional.py
is another problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I advise against trying to use
LintModuleTest
here. The idea is similar but because of the different folder structures it doesn't really work.It's similar to your
Duck
vs.PlasticDuck
example @Pierre-Sassoulas π