Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added no-else-continue message example #6263

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Added no-else-continue message example #6263

merged 4 commits into from
Apr 12, 2022

Conversation

matusvalo
Copy link
Collaborator

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
✓ 📜 Docs

Description

Related #5953

@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 11, 2022
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Apr 11, 2022
Closed
4 tasks
Pierre-Sassoulas
Pierre-Sassoulas reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this example would be easier to understand, let me know what you think :)

doc/data/messages/n/no-else-continue/bad.py Outdated Show resolved Hide resolved
doc/data/messages/n/no-else-continue/good.py Outdated Show resolved Hide resolved
@matusvalo
Copy link
Collaborator Author

matusvalo commented Apr 11, 2022 •
edited
Loading

I personally consider them as equal. We can use any of them.

matusvalo and others added 3 commits April 12, 2022 07:34
@matusvalo @Pierre-Sassoulas
Update doc/data/messages/n/no-else-continue/bad.py
27346f4 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@matusvalo @Pierre-Sassoulas
Update doc/data/messages/n/no-else-continue/good.py
24b22e1 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@matusvalo
Fix good example
19c8aa1
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my suggestion 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit c48365c into pylint-dev:main Apr 12, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Documentation 📗
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matusvalo @Pierre-Sassoulas @DanielNoord