-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yield-outside-function
documentation examples
#6585
Merged
Pierre-Sassoulas
merged 3 commits into
pylint-dev:main
from
mbyrnepr2:yield-outside-function
May 12, 2022
Merged
Add yield-outside-function
documentation examples
#6585
Pierre-Sassoulas
merged 3 commits into
pylint-dev:main
from
mbyrnepr2:yield-outside-function
May 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2309837546
💛 - Coveralls |
…int-errors` project. Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
mbyrnepr2
force-pushed
the
yield-outside-function
branch
from
May 11, 2022 21:44
6825d01
to
d745f55
Compare
4 tasks
DanielNoord
reviewed
May 12, 2022
Comment on lines
1
to
6
def get_values(data): | ||
yield from data | ||
|
||
|
||
for i in get_values(range(10)): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
def get_values(data): | |
yield from data | |
for i in get_values(range(10)): | |
pass | |
def get_values(data): | |
for i in range(10): | |
yield i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha sorry I made the same comment 😄
Pierre-Sassoulas
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
yield-outside-function
documentation examples based on thepyling-errors
project.Co-authored-by: Vladyslav Krylasov vladyslav.krylasov@gmail.com
Type of Changes
Description
Partially addresses #5953