-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.13 #9852
Support Python 3.13 #9852
Conversation
8e1d2fe
to
b54f5ae
Compare
The base branch was changed.
I don't know why the tests aren't running. |
(it seems it's running now, but I swear I did nothing, apart from tuning it off and on again) |
b54f5ae
to
41939d9
Compare
688346e
to
ca4f48e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
@@ -28,7 +28,6 @@ | |||
var7: typing.Hashable # [consider-using-alias] | |||
var8: typing.ContextManager[str] # [consider-using-alias] | |||
var9: typing.Pattern[str] # [consider-using-alias] | |||
var10: typing.re.Match[str] # [consider-using-alias] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't seem worth it to extract this into its own test file that runs on 3.12 and below only. Let's conserve energy.
32d0b63
to
3811903
Compare
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9852 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18932 18935 +3
=======================================
+ Hits 18137 18140 +3
Misses 795 795
|
Towncrier failure should be fixed in next patch release, see twisted/towncrier#632 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! And the current 3.13 is a release candidate so we could release 3.13 support right now (before python 3.13 is officially out, nice) !
Declare support for Python 3.13.