[pre-commit] Add codespell, and fix some existing typos #9912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
This comment has been minimized.
This comment has been minimized.
DanielNoord
reviewed
Sep 5, 2024
| @@ -7,6 +7,9 @@ repos: | |||
| hooks: | |||
| - id: trailing-whitespace | |||
| exclude: tests(/\w*)*/functional/t/trailing_whitespaces.py|tests/pyreverse/data/.*.html|doc/data/messages/t/trailing-whitespace/bad.py | |||
| # - id: file-contents-sorter # commented out because it does not preserve comments order | |||
There was a problem hiding this comment.
Should we just not add it then?
There was a problem hiding this comment.
It's still useful to sort it and then git add -p the changes.
There was a problem hiding this comment.
Yeah but I don't think we should be committing code that is commented out to main right?
There was a problem hiding this comment.
It prevents us from having to recreate the sorting from zero every time we want to sort the file, Is there any downside apart from the file being a little longer ?
There was a problem hiding this comment.
Hmm I think it looks a bit sloppy to have code that you don't intend to use, but I guess it is fine?
| functiondef | ||
| functiΓΈn |
There was a problem hiding this comment.
Yeah should probably remove that instead of sorting it alphabetically π .
There was a problem hiding this comment.
It's used extensively in the unittest for non ascii name
| # tests/functional/m/member/member_checks.py: | ||
| # - typos are voluntary to create credible 'no-member' | ||
|
|
||
| skip = """ |
There was a problem hiding this comment.
There is no way to do inline ignores?
There was a problem hiding this comment.
Not in codespell (make sense as it's used in documentation mainly)
Pierre-Sassoulas
force-pushed
the
add-codespell
branch
from
00dd41f
to
58a3dfb
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9912 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18933 18933
=======================================
Hits 18139 18139
Misses 794 794
|
|
π€ Effect of this PR on checked open source code: π€ Effect on astroid:
The following messages are no longer emitted:
Effect on home-assistant:
The following messages are no longer emitted:
Effect on poetry-core:
The following messages are no longer emitted:
Effect on black:
The following messages are no longer emitted:
Effect on music21:
This comment was truncated because GitHub allows only 65536 characters in a comment. This comment was generated for commit 58a3dfb |
DanielNoord
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Pylint's own checker checks only python files and not other files (rst/md), it also does not check the content of strings inside the code, thus a bunch of new existing typos fixes were made.