Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove privacy.clearOnShutdown.passwords + other obsolete prefs #306

Merged
merged 6 commits into from
May 30, 2017
Merged

remove privacy.clearOnShutdown.passwords + other obsolete prefs #306

merged 6 commits into from
May 30, 2017

Conversation

nodiscc
Copy link
Contributor

@nodiscc nodiscc commented May 29, 2017

Fixes #290

@nodiscc nodiscc changed the title remove privacy.clearOnShutdown.passwords remove privacy.clearOnShutdown.passwords + other obsolete prefs May 30, 2017
// https://hg.mozilla.org/mozilla-central/rev/163997
// http://kb.mozillazine.org/Browser.sessionstore.postdata
// relates to CIS 2.5.7
user_pref("browser.sessionstore.postdata", 0);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be just "browser.sessionstore.postdata"?

Copy link
Contributor Author

@nodiscc nodiscc May 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I just cut-pasted it from user.js and th CI system doesn't complain about it. As long as the pref name is between double quotes it should be fine. I can change it to just "browser.sessionstore.postdata" if it's important.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't matter that much, but just for the sake of consistency. I'll do it.

@pyllyukko pyllyukko self-requested a review May 30, 2017 15:04
@pyllyukko pyllyukko merged commit 7322584 into pyllyukko:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants