Fix flaky test test_deterministic_of_observed_modified_interface
#4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
test_deterministic_of_observed_modified_interfacetest_deterministic_of_observed_modified_interface
brandonwillard
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing frequently in the CI. I think it has to do with the initial values being stochastic and sometimes giving combinations that lead to a derivative underflow in
float32. I fixed the testvals and made sure it passes onfloat32locally.Confidence this will fix issues: 85%
Closes #4661
Edit: to be clear I managed to induce the failure locally by running in a loop and monitoring the random start values. Fixing the observed start values to those made the test fail systematically. I am just not sure this was the only thing that was causing the failures.