Ruff linter

[juanitorduz]

Closes #7084

I tried adding minimal changes to keep up the default ruff configuration (see https://github.com/astral-sh/ruff?tab=readme-ov-file#configuration). Please review carefully 🤓 !

Type of change

• Maintenance

---

📚 Documentation preview 📚: https://pymc--7091.org.readthedocs.build/en/7091/

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7bb2ccd) 92.21% compared to head (ad003e1) 92.23%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7091      +/-   ##
==========================================
+ Coverage   92.21%   92.23%   +0.02%     
==========================================
  Files         101      101              
  Lines       16912    16884      -28     
==========================================
- Hits        15595    15573      -22     
+ Misses       1317     1311       -6     

Files	Coverage Δ
pymc/__init__.py	100.00% <ø> (ø)
pymc/backends/arviz.py	96.98% <100.00%> (+0.46%)	⬆️
pymc/backends/base.py	88.44% <ø> (+2.60%)	⬆️
pymc/distributions/bound.py	100.00% <100.00%> (ø)
pymc/distributions/continuous.py	97.53% <100.00%> (-0.27%)	⬇️
pymc/distributions/discrete.py	99.11% <ø> (ø)
pymc/distributions/multivariate.py	94.11% <100.00%> (+0.57%)	⬆️
pymc/distributions/transforms.py	98.48% <ø> (ø)
pymc/gp/hsgp_approx.py	95.59% <100.00%> (+0.59%)	⬆️
pymc/gp/util.py	96.47% <100.00%> (ø)
... and 24 more

... and 28 files with indirect coverage changes

[juanitorduz]

@ricardoV94 Here are some additional improvements after your first review:

• Revert line-length changes ✅
• Remove all pylint mentions and comments (same for isort) ✅
• Stricter rules trying to avoid global ignore (we just have one now). "Solved" many via #noqa ✅
• Moved some parts of setup.cfg into pyproject.toml. I wanted to remove it all but I need to take care of versioneeer (see 3130413). I will tackle this in another PR.

The pre-commit job goes from 55s -> 23s (on average) after the ruff change. Also, the project dependencies decreased :)

[juanitorduz]

@ricardoV94 I had forgotten to include isort in the config! Now is included! 🙌

[maresb]

This is pretty exciting. We should be able to get rid of pyupgrade too.

[maresb]

This should be "py39", but I don't think we want to tackle that in this PR.

Suggested change

	target-version = "py37"

[maresb]

Similarly for pydocstyle with select "D".

[maresb]

The default rules in ruff are extremely minimalistic. I'd try selecting all of E and also W and check if you can make things stricter (possibly with exceptions) without blowing everything up.

It can be disappointing to have a previously-passing check that doesn't run, and then by the time you discover and fix it, it requires changing substantial parts of the codebase. (I've seen that happen with a malfunctioning line-length check, and then it's a battle to get that under control again.)

[juanitorduz]

The default rules in ruff are extremely minimalistic. I'd try selecting all of E and also W and check if you can make things stricter (possibly with exceptions) without blowing everything up.

It can be disappointing to have a previously-passing check that doesn't run, and then by the time you discover and fix it, it requires changing substantial parts of the codebase. (I've seen that happen with a malfunctioning line-length check, and then it's a battle to get that under control again.)

When I add E I get 252 errors of because of long single docstrings" (E501). Can we tackle this in another PR? Otherwise, this initial change can take ages 😅 .

[maresb]

When I add E I get 252 errors of because of long single docstrings" (E501). Can we tackle this in another PR? Otherwise, this initial change can take ages 😅 .

Of course, just add an ignore for E501.

The point is that there's lots of other things you'll pick up for free or almost for free.

[juanitorduz]

@maresb Thanks for the feedback! I think addressed all your comments. Please let me know if I missed something 🙏

[maresb]

Looks excellent, great work!!!

[ricardoV94]

Thanks a ton guys!

[juanitorduz]

Thanks for your help! Please report any issue and I will try to solve it 💪

[ricardoV94]

@juanitorduz I hear you are doing PyTensor next :D?

[juanitorduz]

There is a PR open so I would not want to interfere 😅. I'll he happy to support though !

[ricardoV94]

I think that one is stale, should be fine to take over (you can ask)