Fix bug from too strict type check in _sum_grad_over_bcasted_dims
#1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
_sum_grad_over_bcasted_dims_sum_grad_over_bcasted_dims
ricardoV94
force-pushed
the
fix_set_subtensor_grad_bug
branch
4 times, most recently
from
055af4d
to
52d7254
Compare
ricardoV94
force-pushed
the
fix_set_subtensor_grad_bug
branch
from
52d7254
to
372abc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in gradient of IncSubtensor reported in https://discourse.pymc.io/t/marginalized-mixture-wont-begin-sampling-throws-assertion-error/15969/10?u=ricardov94
📚 Documentation preview 📚: https://pytensor--1036.org.readthedocs.build/en/1036/