Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ruff #295

Merged
merged 3 commits into from
May 14, 2023
Merged

Add support for ruff #295

merged 3 commits into from
May 14, 2023

Conversation

ricardoV94
Copy link
Member

No description provided.

@ricardoV94 ricardoV94 requested a review from Armavica May 14, 2023 10:12
@ricardoV94 ricardoV94 force-pushed the ruff_support branch 5 times, most recently from 56b71e5 to 605e549 Compare May 14, 2023 11:42
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023 •
edited
Loading

Codecov Report

Merging #295 (33d85e7) into main (6cadc76) will not change coverage.
The diff coverage is 91.66%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   80.37%   80.37%           
=======================================
  Files         153      153           
  Lines       44896    44896           
  Branches    10993    10980   -13     
=======================================
  Hits        36087    36087           
  Misses       6605     6605           
  Partials     2204     2204
Impacted Files Coverage Δ
pytensor/graph/replace.py 84.61% <ø> (ø)
pytensor/graph/rewriting/basic.py 64.27% <0.00%> (ø)
pytensor/link/jax/dispatch/elemwise.py 80.59% <0.00%> (ø)
pytensor/compile/builders.py 77.11% <100.00%> (ø)
pytensor/gradient.py 76.79% <100.00%> (ø)
pytensor/graph/basic.py 88.84% <100.00%> (ø)
pytensor/link/c/basic.py 87.74% <100.00%> (ø)
pytensor/link/c/params_type.py 80.41% <100.00%> (ø)
pytensor/link/numba/dispatch/elemwise.py 89.01% <100.00%> (ø)
pytensor/printing.py 48.94% <100.00%> (ø)
... and 7 more

maresb
maresb reviewed May 14, 2023
View reviewed changes
Copy link
Contributor

@maresb maresb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the rest looks good to me now.

Very nice quality improvement with the comprehensions plugin.

pytensor/graph/rewriting/basic.py Show resolved Hide resolved
maresb
maresb reviewed May 14, 2023
View reviewed changes
pyproject.toml Show resolved Hide resolved
@ricardoV94 ricardoV94 marked this pull request as draft May 14, 2023 14:29
@ricardoV94 ricardoV94 changed the title Add support for Ruff Add support for ruff May 14, 2023
@ricardoV94 ricardoV94 marked this pull request as ready for review May 14, 2023 14:43
@ricardoV94 ricardoV94 requested a review from maresb May 14, 2023 14:43
@ricardoV94 ricardoV94 mentioned this pull request May 14, 2023
Open
@ricardoV94 ricardoV94 merged commit 6b43b43 into pymc-devs:main May 14, 2023
@ricardoV94 ricardoV94 deleted the ruff_support branch May 17, 2023 15:39
@lmmx lmmx mentioned this pull request Dec 7, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maresb maresb maresb approved these changes

@Armavica Armavica Awaiting requested review from Armavica

Assignees
No one assigned
Labels
no releasenotes pre-commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardoV94 @codecov-commenter @maresb