-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page of causal video resources from PyMC community into the docs #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Thanks for this. Can I request a small change?
Remove the level 2 markdown header "PyMC Videos" and instead replace with Level 2 markdown headers with a short video title above each of the videos. Something like:
- Combining Bayes and Graph-based Causal Inference
- Bayesian Causal Modeling
- Guide to Causal Inference with PyMC
oh, and I think we may we well also add in the video from the home page as well seeing as that was pretty much a release announcement for CausalPy.
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
=======================================
Coverage 85.60% 85.60%
=======================================
Files 22 22
Lines 1716 1716
=======================================
Hits 1469 1469
Misses 247 247 β View full report in Codecov by Sentry. |
@drbenvincent , I made the following changes, please let me know if any other change has to be made. Changes
Screenshots |
Excellent. Very minor thing, but can we change |
@drbenvincent I have made the title change, let me know if any other change has to be made? |
Thanks very much for your first contribution @ParthJohri! If you have time, if relevant, I'd be interested to hear about any pain points in the process of contributing. For example, could the I'll slightly modify the PR title simply because that it what will appear in the auto generated release notes. Thanks again! |
No, the |
feat: Add causal videos from PyMC / PyMC Labs community Issue No: 374
closes #374
What type of PR:-
Description
causal_video_resources
page markdown file for the PyMC Labs Videos, used iframe to add the videos.index.md
for the knowledge base to include the page link for thecausal_video_resources
.Screenshot & Screen recording
causal_videos_docs.mov
π Documentation preview π: https://causalpy--379.org.readthedocs.build/en/379/