vueify login page #4634
Merged
vueify login page #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay with exposing the |
sharkykh
previously requested changes
Jul 8, 2018
| name: 'login', | ||
| meta: { | ||
| title: 'Login', | ||
| header: 'Medusa' |
There was a problem hiding this comment.
No header for the login page. It has its own header.
It's not currently an issue, because it doesn't use the VueRouter template (index.mako),
but it will be when it does.
| @@ -49,7 +49,7 @@ | |||
| <link rel="stylesheet" type="text/css" href="css/lib/vue-snotify-material.css?${sbPID}"/> | |||
| <%block name="css" /> | |||
| </head> | |||
| <body ${('data-controller="' + controller + '" data-action="' + action + '" api-key="' + app.API_KEY +'" api-root="' + app.WEB_ROOT + '/api/v2/"', '')[title == 'Login']}> | |||
| <body ${('data-controller="' + controller + '" data-action="' + action + '" api-key="' + app.API_KEY + '"', '')[title == 'Login']} api-root="${app.WEB_ROOT}/api/v2/"> | |||
There was a problem hiding this comment.
Let's expose web-root="${app.WEB_ROOT}" instead.
(see non-review comment above)
| <div class="login"> | ||
| <form action="" method="post"> | ||
| <h1>Medusa</h1> | ||
| <div class="ctrlHolder"><input class="inlay" name="username" type="text" placeholder="Username" autocomplete="off" autocomplete="no" /></div> |
There was a problem hiding this comment.
static/js/templates/login.vue:5:128
✖ 5:128 Duplicate attribute autocomplete. vue/no-duplicate-attributes
✖ 5:128 Parsing error: duplicate-attribute. vue/no-parsing-error
off is the correct value.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Latest commit |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to expose the
api-rootto non-authed users. I can't see this being an issue since they'll need to know this once we move to using the API for authentication anyways.Closes #4624