Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API error when an episode airdate is datetime.date.min #4758

Merged
merged 4 commits into from
Jul 26, 2018
Merged

Fix API error when an episode airdate is datetime.date.min #4758

merged 4 commits into from
Jul 26, 2018

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Jul 26, 2018 •
edited
Loading

Fixes #4633

See: #4633 (comment) for the explanation.
In short, it affected users with timezones smaller than UTC.

Changelog updated in #4756

@sharkykh sharkykh added this to the 0.2.7 milestone Jul 26, 2018
@sharkykh sharkykh mentioned this pull request Jul 26, 2018
Merged
p0psicles
p0psicles previously approved these changes Jul 26, 2018
View reviewed changes
@sharkykh
Copy link
Contributor Author

sharkykh commented Jul 26, 2018 •
edited
Loading

The tests are failing because airDate can now be null.
Before I remove it, I'm going to try to allow for nullable values again...

@sharkykh sharkykh added the Needs testing Requires testing to make sure it's working as intended label Jul 26, 2018
@sharkykh
Copy link
Contributor Author

sharkykh commented Jul 26, 2018 •
edited
Loading

I've fixed all the nullable for Episode & Series objects, and the /alias endpoint.
Needs testing, hold on. Looks good...

I'll do the config endpoint in another PR since it's the biggest change.

@sharkykh sharkykh removed the Needs testing Requires testing to make sure it's working as intended label Jul 26, 2018
OmgImAlexis
OmgImAlexis approved these changes Jul 26, 2018
View reviewed changes
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmgImAlexis OmgImAlexis merged commit 6ecfb0d into develop Jul 26, 2018
@OmgImAlexis OmgImAlexis deleted the bugfix/unaired-episode-date branch July 26, 2018 09:16
@sharkykh sharkykh mentioned this pull request May 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis approved these changes

@p0psicles p0psicles p0psicles left review comments

Assignees
No one assigned
Labels
Bug Concluded
Projects
None yet
Milestone
0.2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@sharkykh @p0psicles @OmgImAlexis