Vueify add show options #4848

p0psicles · 2018-08-05T10:19:00Z

TODO:

finish add-show-options.vue component
release black/white list groups
Update addShows_newShow.mako to use the new component
save default options. We're using vue data now that changes.
The save default button should only be enabled if an option has changed.
error handling when getting black/white lists. For example we cache the bl/wh list in dogpile. So often the api will use that. But when the bl/wh are not available from cache, they are requested through the anidb udp api, which is not that reliable. Requests can timeout. So we should handle that. Maybe give some feedback.

~~To properly use black/white lists from anidb, we need merge another PR, where I implemented dogpile caching for the anidb udp api.~~

A followup (new PR) will be to change all other pages, that use inc_addShowOptions.mako.

addShows_addExistingShow.mako
addShows_recommended.mako
addShows_trendingShows.mako

themes-default/slim/static/js/store.js

@@ -563,5 +570,5 @@ Vue.use(VueNativeSock, websocketUrl, {
    reconnectionAttempts: 2, // (Number) number of reconnection attempts before giving up (Infinity),
    reconnectionDelay: 1000 // (Number) how long to initially wait before attempting a new (1000)
 });
-
+debugger;


sharkykh · 2018-08-06T12:11:49Z

themes/dark/assets/js/templates/add-show-options.vue

@@ -0,0 +1,258 @@
+<template>


Notice you added that SFC to light and dark themes, it is no longer needed, so just remove the files and be sure to merge develop.

I noticed your pr

sharkykh · 2018-08-11T12:39:26Z

themes-default/slim/views/addShows_newShow.mako

-
-                const { providedInfo } = this;
-                const { use, showId, showDir } = providedInfo;
-                if (use && showId !== 0 && showDir) {


Don't remove this part please, it is used to automatically go to the options section when you are adding a show from a folder, with provided metadata from tvshow.nfo

Also use the normal loadsection as I did below and not the new method, because you do want it to go to the last section.

sharkykh

I'm on mobile so not the best review, sorry in advance

sharkykh · 2018-08-11T12:43:26Z

medusa/server/api/v2/config.py

+        section_data['default']['statusAfter'] = common.statusStrings[app.STATUS_DEFAULT_AFTER]
+        section_data['default']['seasonFolders'] = app.SEASON_FOLDERS_DEFAULT
+        section_data['default']['anime'] = app.ANIME_DEFAULT
+        section_data['default']['scene'] = app.SCENE_DEFAULT


Not sure if default is the most descriptive name. Maybe showDefaults? Open to discussion of course...

I think showDefaults is also fine.

sharkykh · 2018-08-11T12:44:05Z

themes-default/slim/src/components/config-toggle-slider.vue

@@ -37,7 +37,7 @@ module.exports = {
    },
    data() {
        return {
-            localChecked: null
+            localChecked: null,


You could just revert this change

sharkykh · 2018-08-11T12:48:20Z

themes-default/slim/views/addShows_newShow.mako

+            formData.append('subtitles', subtitles ? '1' : '0');
+            formData.append('anime', anime ? '1' : '0');
+            formData.append('scene', scene ? '1' : '0');
+            formData.append('season_folders', seasonFolder ? '1' : '0');


All of these can use Number(value) instead of the conditionals, however it should (need to check add_shows.py code) also be working with any truthy value, and I think supplying booleans is the best option in the long term.

Yeah I'd also rather pass booleans. And have the backend translate (as late as possible). Which in the long term should be done by the ORM, when there is no other way supported by db engine.

Changed them to Number(subtitles).. etc.

sharkykh · 2018-08-11T12:50:01Z

themes-default/slim/views/addShows_newShow.mako

+                formData.append('blacklist', name);
+            }
+
+            const statusToDesc = { 'Wanted': 3, 'Skipped': 5, 'Ignored': 7 }


There's a module in the store dedicated specifically for those, statuses, please use it instead of hardcoded values in javascript. We should only hardcode in Python.

No idea how to use that, sorry.

this.$store.state.statuses I think?

OmgImAlexis

Look good overall. 👍

OmgImAlexis · 2018-08-21T09:14:12Z

themes-default/slim/src/components/add-show-options.vue

+import ConfigToggleSlider from './config-toggle-slider.vue';
+import AnidbReleaseGroupUi from './anidb-release-group-ui.vue';
+
+module.exports = {


Should be export default {.

OmgImAlexis · 2018-08-21T09:15:06Z

themes-default/slim/src/components/add-show-options.vue

+        AnidbReleaseGroupUi,
+        ConfigToggleSlider
+    },
+    props: ['selectedShow'],


Needs type and possibly default.

OmgImAlexis · 2018-08-21T09:20:56Z

themes-default/slim/src/components/add-show-options.vue

+        },
+        selectedSceneEnabled() {
+            this.update();
+        },


These should be moved to mounted with something like this.

this.$watch(vm => [ vm.selectedAnimeEnabled, vm.selectedStatus, vm.selectedStatusAfter, vm.selectedSeasonFolderEnabled, vm.selectedSceneEnabled ].join(), () => { this.update() });

OmgImAlexis · 2018-08-21T09:21:25Z

themes-default/slim/views/addShows_newShow.mako

@@ -212,13 +226,33 @@ window.app = new Vue({
                }

                // Converts select boxes to command separated values [js/blackwhite.js]
-                generateBlackWhiteList(); // eslint-disable-line no-undef
+                //generateBlackWhiteList(); // eslint-disable-line no-undef


Remember to add/remove this before merge.

OmgImAlexis · 2018-08-21T09:21:43Z

themes-default/slim/views/addShows_newShow.mako


                formData = new FormData(this.$refs.addShowForm);
            }

            this.otherShows.forEach(nextShow => formData.append('other_shows', nextShow));

+            // Because we're using te toggle-button.vue component, we don't have valid form input's for these.


Missing "h" in "the".

Stale

OmgImAlexis · 2018-08-28T23:14:24Z

@sharkykh pretty sure there's still the issue of hitting "search" while a search is going just cancels instead of starting the new one.

sharkykh · 2018-08-28T23:18:40Z

@OmgImAlexis That's the first time I'm reading about it... On develop?

OmgImAlexis · 2018-08-29T00:46:16Z

@sharkykh it's been there for a while now. If you click the "search" again it works. Pretty sure master has the same issue.

* Make addShows_newShow.mako use the component to configure the new shows options and send the options when adding a new show. * Fix anidb-release-group-ui.vue, update the data when property get's updated after mount. * Fix config-textbox, config-textbox-number.vue, config-toggle-slider.vue. * Update config.py, make sure the status and statusAfter are send as Strings not the numbers.

* Clicking enter triggered saving add show defaults * Clicking enter triggered native form submission

The original `addShowOptions` had that, this should too. + Add comment that the `QualityChooser` component should be imported

sharkykh · 2018-09-07T17:06:06Z

@p0psicles About that last "to-do", is it just you want to handle errors when calling home/fetch_releasegroups and show a message to the user?

p0psicles · 2018-09-07T17:10:36Z

More like what i recently implemented. Its not relevant anymore

- Add notification about error getting release groups - Remove commented out notification

p0psicles · 2018-09-10T13:50:53Z

Lets merge?

sharkykh · 2018-09-10T15:03:58Z

Sure, hopefully I didn't miss anything big.

p0psicles · 2018-09-10T15:22:10Z

Faster we merge faster we notice.

p0psicles · 2018-09-10T15:22:39Z

Tnx for your help @sharkykh

OmgImAlexis reviewed Aug 5, 2018

View reviewed changes

p0psicles added Enhancement In progress Bug labels Aug 5, 2018

sharkykh reviewed Aug 6, 2018

View reviewed changes

sharkykh reviewed Aug 11, 2018

View reviewed changes

sharkykh previously requested changes Aug 11, 2018

View reviewed changes

OmgImAlexis mentioned this pull request Aug 21, 2018

Vueify #4058

Open

p0psicles assigned OmgImAlexis Aug 21, 2018

p0psicles added this to the 0.2.9 milestone Aug 21, 2018

OmgImAlexis previously approved these changes Aug 21, 2018

View reviewed changes

OmgImAlexis added the Squash / Rebase label Aug 21, 2018

sharkykh added the Changelog Requires a changelog entry label Aug 23, 2018

sharkykh self-assigned this Aug 24, 2018

sharkykh dismissed OmgImAlexis’s stale review via 97097f4 August 24, 2018 14:59

This comment has been minimized.

Sign in to view

sharkykh force-pushed the feature/vue-add-show-options branch 2 times, most recently from 54b5c7c to d2770ae Compare August 25, 2018 10:52

This comment has been minimized.

Sign in to view

sharkykh force-pushed the feature/vue-add-show-options branch from d2770ae to 2633509 Compare August 28, 2018 23:05

This comment has been minimized.

Sign in to view

p0psicles added 3 commits August 29, 2018 17:39

Add default options to apiv2 /config

550a1ad

Update store.js with new default (add-show) options.

a31c9ca

sharkykh added 5 commits September 2, 2018 17:26

Merge branch 'develop' into feature/vue-add-show-options

cb0f236

Test utils.combineQualities

3e3966b

Merge branch 'develop' into feature/vue-add-show-options

88dec5c

Fixes for clicking enter on the show name search input

f6f053e

* Clicking enter triggered saving add show defaults * Clicking enter triggered native form submission

Fix toggle-slider value not updated when prop value is updated

d2fd220

sharkykh force-pushed the feature/vue-add-show-options branch from bcc9f6a to d2fd220 Compare September 2, 2018 23:39

Update changelog

36ff6fe

sharkykh removed the Changelog Requires a changelog entry label Sep 4, 2018

This comment has been minimized.

Sign in to view

sharkykh added 2 commits September 4, 2018 19:52

Only show anime option if enableAnimeOptions prop is true

d531365

The original `addShowOptions` had that, this should too. + Add comment that the `QualityChooser` component should be imported

Merge branch 'develop' into feature/vue-add-show-options

785f062

medariox modified the milestones: 0.2.9, 0.2.10 Sep 4, 2018

sharkykh added the Squash / Rebase label Sep 7, 2018

sharkykh added 3 commits September 7, 2018 22:13

Merge branch 'develop' into feature/vue-add-show-options

a48bf70

Update notifications

6217121

- Add notification about error getting release groups - Remove commented out notification

Merge branch 'develop' into feature/vue-add-show-options

4fe1a64

Add missing apiRoute import

67e9813

sharkykh added Concluded and removed In progress Squash / Rebase labels Sep 10, 2018

sharkykh approved these changes Sep 10, 2018

View reviewed changes

p0psicles merged commit a0a3d42 into develop Sep 10, 2018

p0psicles deleted the feature/vue-add-show-options branch September 10, 2018 15:22

Vueify add show options #4848

Vueify add show options #4848

Conversation

p0psicles commented Aug 5, 2018 • edited by sharkykh Loading

TODO:

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sharkykh Aug 11, 2018 • edited Loading

Choose a reason for hiding this comment

sharkykh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OmgImAlexis left a comment

Choose a reason for hiding this comment

OmgImAlexis Aug 21, 2018 • edited by sharkykh Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

OmgImAlexis commented Aug 28, 2018

sharkykh commented Aug 28, 2018

OmgImAlexis commented Aug 29, 2018

This comment has been minimized.

sharkykh commented Sep 7, 2018

p0psicles commented Sep 7, 2018

p0psicles commented Sep 10, 2018

sharkykh commented Sep 10, 2018

p0psicles commented Sep 10, 2018

p0psicles commented Sep 10, 2018

p0psicles commented Aug 5, 2018 •

edited by sharkykh

Loading

sharkykh Aug 11, 2018 •

edited

Loading

OmgImAlexis Aug 21, 2018 •

edited by sharkykh

Loading