Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guessit exception when parsing release without title. Fixes #5568 #5569

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fix guessit exception when parsing release without title. Fixes #5568 #5569

merged 2 commits into from
Oct 31, 2018

Conversation

medariox
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@medariox medariox added this to the 0.2.12 milestone Oct 31, 2018
@medariox medariox mentioned this pull request Oct 31, 2018
Closed
@medariox medariox merged commit cf15ecf into develop Oct 31, 2018
@medariox medariox deleted the fix/guessit-rel-no-title branch October 31, 2018 12:22
@ratoaq2
Copy link
Contributor

ratoaq2 commented Oct 31, 2018

It helps adding the scenario to the yaml file to avoid regressions

@medariox
Copy link
Contributor Author

You're right ofc, will try to remember next time. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Concluded
Projects
None yet
Milestone
0.2.12
Development

Successfully merging this pull request may close these issues.
3 participants
@medariox @ratoaq2 @p0psicles