Feature/fix create cache from meta #5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DeepCode analyzed this pull request. |
medariox
reviewed
Dec 1, 2018
medusa/metadata/generic.py
Outdated
| def get_image_path(self, show_obj, image_type): | ||
| """Based on the image_type (banner, poster, fanart) call the correct method, and return the path.""" | ||
| banner_path = { | ||
| BANNER: self.get_banner_path, POSTER: self.get_poster_path, FANART: self.get_fanart_path |
There was a problem hiding this comment.
I would put one on each line:
BANNER: self.get_banner_path,
POSTER: self.get_poster_path,
FANART: self.get_fanart_path,
medariox
reviewed
Dec 1, 2018
medusa/metadata/generic.py
Outdated
| BANNER: self.get_banner_path, POSTER: self.get_poster_path, FANART: self.get_fanart_path | ||
| } | ||
| if banner_path.get(image_type): | ||
| return banner_path.get(image_type)(show_obj) |
There was a problem hiding this comment.
You can avoid the second .get() here and just use banner_path[image_type](show_obj)
medariox
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5808