Remove forcedSearchQueueItem, in favor of using backlogQueueItem for single ep searches #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forced searches are now using the BacklogQueueItem. But the search is placed in the forced_search_queue_scheduler scheduler. This means that a scheduled proper, backlog or daily search will not interfere with a forced search
|
DeepCode analyzed this pull request. Click to see more details. |
|
DeepCode analyzed this pull request. Click to see more details. |
34 tasks
5 tasks
…move-forced-search # Conflicts: # medusa/server/api/v2/search.py
|
@medariox this one is next. If you have some time? |
medariox
reviewed
Aug 31, 2019
medusa/search/queue.py
Outdated
|
|
||
| # Set the search_type for the result. | ||
| result.search_type = SearchType.FORCED_SEARCH | ||
| search_result = search_providers(self.show, self.segment, True, True, |
There was a problem hiding this comment.
I think it would be better to use named arguments here, especially for the Trues. It makes it much more readable.
medusa/search/queue.py
Outdated
| if isinstance(self.currentItem, (ForcedSearchQueueItem, FailedQueueItem)): | ||
| """Test of a forced search is currently running (can be backlog, manual or failed search). | ||
|
|
||
| it doesn't check what's in queue. |
There was a problem hiding this comment.
This should be capitalized for consistency.
medariox
approved these changes
Sep 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forced searches are now using the BacklogQueueItem.
But the search is placed in the forced_search_queue_scheduler scheduler.
This means that a scheduled proper, backlog or daily search will not interfere with a forced search
used in #6709