Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase 'e' in multi-episode split naming #6910

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Lowercase 'e' in multi-episode split naming #6910

merged 3 commits into from
Jul 3, 2019

Conversation

nmaggioni
Copy link
Contributor

I came across a few split episodes and noticed that the naming couldn't be made coherent with the rest of my scheme: the E for the second episode in a split was forcibly uppercase. This PR introduces an additional dropdown value to make it lowercase.

Before:
Before

After (additional option):
After


  • PR is based on the DEVELOP branch
  • Don't send big changes all at once.
  • Read the contribution guide

@p0psicles
Copy link
Contributor

You have to refresh the snapshots. jest --updateSnapshot.

@p0psicles
Copy link
Contributor

Also fix import order .
tv/episode.py:27:1: I101 Imported names are in the wrong order. Should be ARCHIVED, DOWNLOADED, NAMING_DUPLICATE, NAMING_EXTEND, NAMING_LIMITED_EXTEND, NAMING_LIMITED_EXTEND_E_LOWER_PREFIXED, NAMING_LIMITED_EXTEND_E_UPPER_PREFIXED, NAMING_SEPARATED_REPEAT, Quality, SKIPPED, SNATCHED, SNATCHED_BEST, SNATCHED_PROPER, UNAIRED, UNSET, WANTED, statusStrings

@nmaggioni
Copy link
Contributor Author

Sorry, I couldn't find much info on the testing setup - I should have looked directly at CI runs.

@p0psicles
Copy link
Contributor

Can you add a small changelog line in CHANGELOG.md?

@p0psicles p0psicles merged commit 8d6ed43 into pymedusa:develop Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants