Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks that prevent adding show without any episodes. #6977

Merged
merged 12 commits into from
Sep 25, 2019

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Jul 25, 2019

For example status 'upcoming'

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Was able to add show star trek picard with some minor adjustments to the code.
Really wondering if there are any other reasons why we don't support this?

Just running some tests to see if implementing this is desirable/possible: #6730

tested indexers

  • tvdb: star trek picard
  • tvmaze: star trek picard
  • tmdb: the witcher (2020)

@p0psicles
Copy link
Contributor Author

@medariox what do you think?

@medariox
Copy link
Contributor

I think we can try it. Not in this release, but the next. But all indexers need to be supported, not just theTVDB.

@p0psicles p0psicles marked this pull request as ready for review September 15, 2019 11:00
@p0psicles
Copy link
Contributor Author

@medariox shall we clean up the lint errors and merge?

@medariox
Copy link
Contributor

Sure. What about tvmaze?

@medariox
Copy link
Contributor

We should also consider #6832 for this PR.

@p0psicles
Copy link
Contributor Author

p0psicles commented Sep 24, 2019

I've added it

@medariox medariox added this to the 0.3.6 milestone Sep 25, 2019
@p0psicles p0psicles merged commit 130b8cf into develop Sep 25, 2019
@p0psicles p0psicles deleted the feature/allow-add-show-without-eps branch September 25, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants