Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back code to use season images for TVDB API #7460

Merged
merged 2 commits into from
Dec 8, 2019
Merged

Bring back code to use season images for TVDB API #7460

merged 2 commits into from
Dec 8, 2019

Conversation

medariox
Copy link
Contributor

@medariox medariox commented Dec 8, 2019

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

It had been removed because theTVDB API was faulty. They fixed it now so we can keep getting the season images.

@medariox medariox added this to the 0.3.8 milestone Dec 8, 2019
@p0psicles
Copy link
Contributor

Was this broken?

@medariox
Copy link
Contributor Author

medariox commented Dec 8, 2019

Yeah, I had to remove it because sub_key was returning graphical instead of the season no.

@medariox medariox merged commit d1befd3 into develop Dec 8, 2019
@medariox medariox deleted the fix/bb-season-imgs-tvdb branch December 8, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

Assignees
No one assigned
Labels
Concluded Enhancement
Projects
None yet
Milestone
0.3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@medariox @p0psicles