-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run WindowsSelectorEventLoop event loop explicit on windows and py3. #7940
Conversation
p0psicles
commented
Apr 9, 2020
•
edited
Loading
edited
- Required from python3.8.
- PR is based on the DEVELOP branch
- Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
- Read the contribution guide
* Required from python3.8.
FYI this will throw an exception for Python 3.5 and 3.6 as
More info from Tornado:
I suggest # We need to set the WindowsSelectorEventLoop event loop on python 3 (3.8 and higher) running on windows
if sys.platform == 'win32':
try:
asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())
except AttributeError: # Only available since Python 3.7.0
pass |
@sharkykh |
From what is Read was that it was always available below 3.8. But from 3.8 needed to be set explicitly. Good to know. |
@medariox Sure #7942 |