Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor scene exception methods #8753

Merged
merged 17 commits into from
Nov 19, 2020
Merged

Refactor scene exception methods #8753

merged 17 commits into from
Nov 19, 2020

Conversation

medariox
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

I wasn't able to understand much with the old code, so I decided to refactor it.
Needs to be tested thoroughly.

@medariox medariox added Enhancement Concluded Needs testing Requires testing to make sure it's working as intended labels Nov 18, 2020
@medariox medariox added this to the 0.4.6 milestone Nov 18, 2020
@medariox
Copy link
Contributor Author

Merging to get some early feedback.

@medariox medariox merged commit 29be151 into develop Nov 19, 2020
@medariox medariox deleted the feature/improve-scene-ex branch November 19, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Concluded Enhancement Needs testing Requires testing to make sure it's working as intended
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@medariox @renovate-bot