Added the CHANGE_* methods from medusa.config.py #8948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used these methods in set properties of their app variables.
* Make sure we don't run or change threads, when there is nothing to change.
|
@medariox aah great. Another one of those "pyTest is running fine locally, but not on build slave" |
…x-start-thread-config-change # Conflicts: # medusa/app.py # medusa/config.py
As from 6.2.0 it will error on `attrs() got an unexpected keyword argument 'eq'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used these methods in set properties of their app variables.
@medariox with the vueification we lost the ability to "hot-reload" the threads and their settings.
I used @Property now to accomplish the same as what we had in the server/web/config/handler.py routes.