Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix remove show #9563

Merged
merged 6 commits into from
Jun 2, 2021
Merged

Feature/fix remove show #9563

merged 6 commits into from
Jun 2, 2021

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented May 21, 2021 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

fix #9553

@p0psicles
Send showRemove message to frontend.
262fd6f 
* Don't redirect on show removal, as we want to handle that in the frontend, without page reloads.
@p0psicles
Remove show from store + localStorage on show removal.
8700dd4
@p0psicles p0psicles mentioned this pull request May 21, 2021
Closed
@p0psicles p0psicles added this to the 0.5.13 milestone Jun 2, 2021
@p0psicles p0psicles added the Bug label Jun 2, 2021
@p0psicles p0psicles merged commit 2fb00d1 into develop Jun 2, 2021
@p0psicles p0psicles deleted the feature/fix-remove-show branch June 2, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.5.13
Development

Successfully merging this pull request may close these issues.
1 participant
@p0psicles