Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate implicit optional for CommParams types #1825

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

alexrudd2
Copy link
Collaborator

Explicitly add | None to remove ~11 errors with mypy.no_explicit_optional = True.

CommParams is a dataclass, and consumers of this class either
(1) Have default values that will stand in for None
(2) Totally ignore the values (for instance, serial ignore TCP params, and vice versa)

Thanks to @MAKOMO

Co-authored-by: MAKOMO <marko.luther@gmx.net>
@janiversen janiversen merged commit 1c37fe9 into dev Oct 17, 2023
1 check passed
@janiversen janiversen deleted the typing-CommParams branch October 17, 2023 07:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants