Picoprobe: fix for uid being specified with no available Picoprobes. #1117
Conversation
|
cc @newbrain I sent you an invitation to be a collaborator so you can review the code. |
flit
force-pushed
the
bugfix/picoprobe_uid
branch
from
9a04490 to
7972e85
Compare
|
Weird. After I forced pushed a little fix, the checks didn't run. I'll have to add some other change to see if it runs with another added commit. |
flit
force-pushed
the
bugfix/picoprobe_uid
branch
from
7972e85 to
5548e26
Compare
|
Force pushing triggered the checks this time. 🤷🏽 |
| @@ -101,13 +102,10 @@ def close(self): | |||
| self._rd_ep = None | |||
|
|
|||
| @classmethod | |||
| def enumerate_picoprobes(cls, uid=None): | |||
| def enumerate_picoprobes(cls, uid=None) -> List["PicoLink"]: | |||
There was a problem hiding this comment.
I must admit this was new to me. Oh well, more PEPs to read...
There was a problem hiding this comment.
Yeah. It's all pretty new to me, too. 😄 As long as I've been using python, I haven't been able to use any of the Python 3 features because Python 2 compatibility was required in everything I worked on. So I'm going to start trying to add some type annotations to pyocd to better document the APIs.
And if you think type annotations are fun, check out PEP 638. 😁
Fixes #1116