Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: stlink: fix broken non-word-aligned 8-bit transfers #1428

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

flit
Copy link
Member

@flit flit commented Jul 5, 2022

Fix for an embarrassing bug introduced when STLink HPROT/HNONSEC support was added.

Fixes #1409

@flit flit merged commit b80193c into pyocd:main Jul 5, 2022
@flit flit deleted the bugfix/stlink_unaligned_8 branch July 5, 2022 22:04
Copy link

@DariusBabrauskas DariusBabrauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note. It seems mistake. Because :

  1. First need read8 until aligned address. There is mistake - prewios code was ok. But need check size with unaligned_count
  2. Then read32 until last aligned adress.
  3. Read8 last not aligned adress data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakpoint causes unhandled exeception
2 participants